Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(job): Check if carddata is resource and read it to string #49332

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(job): Check if carddata is resource and read it to string #49332

merged 1 commit into from
Nov 19, 2024

Conversation

wolandtel
Copy link
Contributor

Check if oc_cards.carddata has been read as resource and read it to string.

@solracsf solracsf added this to the Nextcloud 31 milestone Nov 16, 2024
@solracsf solracsf added 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Nov 16, 2024
@solracsf solracsf changed the title Fix bug nextcloud/server#46100 fix(job): Check if carddata is resource and read it to string Nov 16, 2024
@ChristophWurst ChristophWurst requested review from st3iny and removed request for miaulalala November 18, 2024 07:56
ChristophWurst
ChristophWurst reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

apps/dav/lib/Migration/BuildSocialSearchIndexBackgroundJob.php Outdated Show resolved Hide resolved
ChristophWurst
ChristophWurst approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into one, then we are ready for shipping :shipit:

@joshtrichards
Copy link
Member

/backport to stable30

@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards
Copy link
Member

/backport to stable28

@solracsf
Copy link
Member

Please squash your commits into one, then we are ready for shipping :shipit:

And commit as fix(job): Check if carddata is resource and read it to string :)

@wolandtel @ChristophWurst
fix(job): Check if carddata is resource and read it to string
e9d6c50 
Fixes nextcloud#46100

Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Mikhail Kotelnikov <fox@woland.me>
@wolandtel
Copy link
Contributor Author

done

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 19, 2024
@skjnldsv skjnldsv merged commit 8f6ef39 into nextcloud:master Nov 19, 2024
173 of 176 checks passed
@welcome Welcome
Copy link

welcome bot commented Nov 19, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

This was referenced Nov 19, 2024
Merged
Merged
@backportbot backportbot

This comment was marked as resolved.

Sign in to view
@skjnldsv
Copy link
Member

/backport to stable30

@backportbot backportbot

This comment was marked as resolved.

Sign in to view
@solracsf
Copy link
Member

/backport to stable30

@backportbot backportbot bot mentioned this pull request Nov 20, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: carddav Related to CardDAV internals feedback-requested
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: Error while running background job OCA\\DAV\\Migration\\BuildSocialSearchIndexBackgroundJob
6 participants
@wolandtel @joshtrichards @solracsf @skjnldsv @ChristophWurst @SebastianKrupinski