fix: throw correct exception type when we can't verify if an s3 bucket exists #49494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exists Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
nfebe,
provokateurin and
come-nc
and removed request for
a team
provokateurin
approved these changes
Nov 26, 2024
|
/backport to stable30 |
|
/backport to stable29 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
s3-bucket-create-exception
branch
from
f1cd775 to
b2c0178
Compare
artonge
approved these changes
Nov 26, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
This was referenced Nov 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure it can be handled as an unavailable storage.
Includes a bonus fix for the availability wrapper.