Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use absolute urls in SCSS #5137

Closed
wants to merge 1 commit into from
Closed

Conversation

juliusknorr
Copy link
Member

Absolute urls will not work with multiple trusted domains, since they are cached here.

Fix for #5085

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@mention-bot
Copy link

@juliushaertl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @schiessle and @nickvergessen to be potential reviewers.

@nickvergessen
Copy link
Member

We can also have one cache per domain...
Why did we use absolute urls in firstplace? There has to be a reason

@juliusknorr
Copy link
Member Author

We can also have one cache per domain...

That would be pretty bad, since then we would need to store an individual cached css file for each domain as well.

Why did we use absolute urls in firstplace? There has to be a reason

Not sure about that, I remember some issues with Nextcloud not running in root but I've tested that with the proposed changes and it works as well.

@nickvergessen
Copy link
Member

Hmm is it possible that the problem is when two urls use a different subpath (folder)?

@juliusknorr
Copy link
Member Author

@nickvergessen Is that something that is possible to configure?

So to summarize we can have one Nextcloud instance that can be accessed by the following set of URLs:
https://domain1.example.com/
https://domain2.example.com/
https://domain3.example.com/nextcloud/

Is there anything missing?

So i guess we should cache scss files then for each of this combinations of server host and subdirectories.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and still works 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Jun 15, 2017
@MorrisJobke MorrisJobke deleted the fix-theming-absolute-url branch June 16, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants