Display app names in user's language when upgrading.

[tcitworld]

Fixes #6024

Before:

After:

[codecov]

Codecov Report

Merging #6025 into master will decrease coverage by 16.03%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #6025       +/-   ##
=============================================
- Coverage     53.06%   37.02%   -16.04%     
- Complexity    22553    22769      +216     
=============================================
  Files          1414     1405        -9     
  Lines         87745    88171      +426     
  Branches       1340     1327       -13     
=============================================
- Hits          46560    32648    -13912     
- Misses        41185    55523    +14338

Impacted Files	Coverage Δ	Complexity Δ
lib/private/App/AppManager.php	65.44% <0%> (-30.15%)	47 <8> (ø)
lib/base.php	2.89% <0%> (ø)	173 <0> (ø)	⬇️
apps/dav/lib/CalDAV/Activity/Filter/Todo.php	0% <0%> (-100%)	7% <0%> (ø)
apps/sharebymail/lib/Settings.php	0% <0%> (-100%)	3% <0%> (ø)
apps/dav/lib/Files/Sharing/FilesDropPlugin.php	0% <0%> (-100%)	6% <0%> (ø)
...Check/Iterator/ExcludeFileByNameFilterIterator.php	0% <0%> (-100%)	2% <0%> (ø)
lib/private/Files/SimpleFS/SimpleFolder.php	0% <0%> (-100%)	11% <0%> (ø)
lib/public/RichObjectStrings/Definitions.php	0% <0%> (-100%)	2% <0%> (ø)
lib/private/Template/ResourceNotFoundException.php	0% <0%> (-100%)	2% <0%> (ø)
apps/dav/lib/CalDAV/Plugin.php	0% <0%> (-100%)	2% <0%> (ø)
... and 616 more

[MorrisJobke]

Tested and works 👍

[LukasReschke]

Rebased to retrigger tests.

[MorrisJobke]

There was 1 failure:

1) Test\Authentication\TwoFactorAuth\ManagerTest::testGetBackupProvider

Failed asserting that null is identical to an object of class "Mock_IProvider_8d699353".

/drone/src/github.com/nextcloud/server/pull/6025/tests/lib/Authentication/TwoFactorAuth/ManagerTest.php:218

[rullzer]

failing tests

[tcitworld]

So I don't know why but it seems phpunit's returnValueMap() was causing trouble with optional arguments.

[nickvergessen]

You have to specify optional arguments all the time in the map

[tcitworld]

You have to specify optional arguments all the time in the map

I tried that too, but it didn't work. :'(

[MorrisJobke]

I still vote for extracting this in the l10n process and let transifex handle this. Then we should read the app name and description for the l10n files instead of hacking this into the info.xml.

[tcitworld]

@MorrisJobke I'm not sure to understand your comment. 😕

[MorrisJobke]

@MorrisJobke I'm not sure to understand your comment. 😕

Currently translations of an app are handled via our l10n/ folder holding all the translated files. This is also the case for the app name. The app name is already extracted from info.xml and put on transifex. That means that our UI (apps management, app navigation) can use the translated app name without any further requirements.

The info.xml somehow still has this lang="fr" attribute build in, that is nowhere used (beside in 2 apps) and the same for the description. It would just make sense to not maintain those translations within the info.xml, but also take them, put them on transifex and put the translated terms into the l10n folder like all other translations of an app.

[tcitworld]

OK, so this would mean :

• extract the description text just like the app name and put it into transifex
• tweak the nextcloud apps page and the app store to display name and description according to contents of l10n and not just info.xml
• Explain to app maintainers who don't use transifex for their app that they need to put the name and description strings in the l10n files.

[nickvergessen]

tweak the nextcloud apps page and the app store to display name and description according to contents of l10n and not just info.xml

Well it's easier, we "just" do \OC::$server->getL10N($appId)->t($appName) and \OC::$server->getL10N($appId)->t($data['description'])

[MorrisJobke]

Explain to app maintainers who don't use transifex for their app that they need to put the name and description strings in the l10n files.

They either don't translate or reach out to us to get the transifex integration. So I don't see this as a problem.

[MorrisJobke]

They either don't translate or reach out to us to get the transifex integration. So I don't see this as a problem.

Let's get this done: nextcloud/docker-ci#93

Then it is properly translatable in transifex and we don't need to keep this in sync manually for all the apps.