Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part2] Make thunderbird and outlook addons identifyable #8690

Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 6, 2018

part 2 of too early merged #8565 (if back ported it should be back ported together with that fix)

Let's wait with merging for confirmation by:

@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Mar 6, 2018
@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 6, 2018
@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #8690 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8690      +/-   ##
============================================
- Coverage      51.9%   51.87%   -0.03%     
+ Complexity    25365    25354      -11     
============================================
  Files          1607     1606       -1     
  Lines         95326    95077     -249     
  Branches       1394     1378      -16     
============================================
- Hits          49481    49324     -157     
+ Misses        45845    45753      -92
Impacted Files Coverage Δ Complexity Δ
...are/Security/Exceptions/AppNotEnabledException.php 0% <0%> (-100%) 1% <0%> (ø)
...aring/lib/Controller/MountPublicLinkController.php 21.52% <0%> (-20.37%) 24% <0%> (+10%)
...B/QueryBuilder/FunctionBuilder/FunctionBuilder.php 61.53% <0%> (-16.24%) 6% <0%> (-3%)
lib/public/Util.php 44.28% <0%> (-15.91%) 59% <0%> (+14%)
lib/private/Route/Route.php 26.08% <0%> (-15.22%) 14% <0%> (ø)
core/js/sharedialogview.js 75.43% <0%> (-12.11%) 0% <0%> (ø)
lib/private/User/Database.php 68.99% <0%> (-10.07%) 45% <0%> (+3%)
lib/private/Mail/Message.php 79.16% <0%> (-6.36%) 24% <0%> (-5%)
lib/private/legacy/app.php 57.89% <0%> (-4.75%) 198% <0%> (+2%)
lib/public/Share.php 35.29% <0%> (-4.71%) 7% <0%> (+1%)
... and 172 more

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/8565/make-thunderbird-and-outlook-addons-identifyable branch from 5a24f17 to 1fbfe7b Compare April 19, 2018 08:32
@MorrisJobke MorrisJobke added the stale Ticket or PR with no recent activity label Jun 19, 2018
@MorrisJobke
Copy link
Member

Nothing for 14 it seems -> moved to 15

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 29, 2018
@rullzer
Copy link
Member

rullzer commented Aug 8, 2018

@nickvergessen so merge this for 14 is the plan right? Then the outlook plugin (and soonish maybe the filelink thunderbird thingy) can be used as well there.

@nickvergessen
Copy link
Member Author

yes

@rullzer rullzer modified the milestones: Nextcloud 15, Nextcloud 14 Aug 9, 2018
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 9, 2018
@rullzer rullzer mentioned this pull request Aug 9, 2018
58 tasks
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🐘

@rullzer rullzer merged commit a21c93a into master Aug 9, 2018
@rullzer rullzer deleted the feature/8565/make-thunderbird-and-outlook-addons-identifyable branch August 9, 2018 07:55
@MorrisJobke
Copy link
Member

@nickvergessen @rullzer I guess we don't backport this, right?

@MorrisJobke MorrisJobke mentioned this pull request Aug 22, 2018
8 tasks
@nickvergessen
Copy link
Member Author

Fine by me

@MorrisJobke
Copy link
Member

Fine by me

Let's do it for 13.0.7

@MorrisJobke
Copy link
Member

Let's not backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants