-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various css fixes #8777
Various css fixes #8777
Conversation
@@ -319,7 +325,7 @@ kbd { | |||
margin: 0; | |||
z-index: 110; | |||
} | |||
&:after { | |||
&:before { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have a icon-loading, the after is already used. Let's use the before for the collapsible triangle indicator
Failure unrelated |
@skjnldsv Any places where this causes problems, so we can test that easily? |
@juliushaertl for the confirm icon, not really! I encountered it in a test, so this is a css prop just in case. (z index can be reviewed as code, it's a simple edit) For the icon loading navigation, easy one, remove all the entries in the app-navigation (on any nextcloud page you want), and add this instead:
Toggle the |
Fixed bullet/icon combination visibility Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
1d90a34
to
ffa2eae
Compare
Codecov Report
@@ Coverage Diff @@
## master #8777 +/- ##
===========================================
- Coverage 51.82% 51.32% -0.5%
- Complexity 25281 25380 +99
===========================================
Files 1604 1542 -62
Lines 94804 87342 -7462
Branches 1377 0 -1377
===========================================
- Hits 49131 44828 -4303
+ Misses 45673 42514 -3159
|
Failure unrelated: Once merged, backport of the icon-confirm will be needed for backward compatibility of some apps that uses it. |
Bump? @nextcloud/designers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
@skjnldsv RC time means time for backports 😉 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
[stable13] backport various scss fixes #8777
@nextcloud/designers easy one ;)