-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable13] Show EOL warning in the update section #8986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
enhancement
3. to review
Waiting for reviews
feature: install and update
labels
Mar 26, 2018
This was referenced Mar 26, 2018
MorrisJobke
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Rebased to retrigger CI |
MorrisJobke
force-pushed
the
backport/8821/show-eol-warning
branch
from
April 12, 2018 09:38
9321eb1
to
5c0ec6e
Compare
Codecov Report
@@ Coverage Diff @@
## stable13 #8986 +/- ##
===============================================
- Coverage 51.33% 34.64% -16.69%
- Complexity 25040 25042 +2
===============================================
Files 1609 1609
Lines 95317 95325 +8
Branches 1376 1376
===============================================
- Hits 48929 33030 -15899
- Misses 46388 62295 +15907
|
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
backport/8821/show-eol-warning
branch
from
April 18, 2018 11:46
5c0ec6e
to
6b97429
Compare
Rebased and fixed the last failing test |
rullzer
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8821