Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert email addresses with idn_to_ascii if… #9095

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Do not convert email addresses with idn_to_ascii if… #9095

merged 1 commit into from
Apr 6, 2018

Conversation

JaredBoone
Copy link
Contributor

… INTL_IDNA_VARIANT_UTS46 is undefined.

Fixes #8387.

…_UTS46 is undefined.

Fixes #8387.

Signed-off-by: Jared Boone <jared.boone@gmail.com>
@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #9095 into stable13 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable13    #9095      +/-   ##
==============================================
- Coverage       51.33%   51.33%   -0.01%     
- Complexity      25029    25031       +2     
==============================================
  Files            1609     1609              
  Lines           95307    95307              
  Branches         1376     1376              
==============================================
- Hits            48930    48929       -1     
- Misses          46377    46378       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Mail/Message.php 79.16% <100%> (ø) 25 <0> (+1) ⬆️
lib/private/Mail/Mailer.php 59.77% <100%> (ø) 28 <0> (+1) ⬆️
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@JaredBoone
Copy link
Contributor Author

I pushed a commit log rewrite to add my sign-off

@rullzer
Copy link
Member

rullzer commented Apr 5, 2018

@JaredBoone thanks!

Could you also open a PR against master for this?

@JaredBoone
Copy link
Contributor Author

@rullzer Sure. Here's the PR against master: #9100.

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 6, 2018
@MorrisJobke
Copy link
Member

@MorrisJobke
Copy link
Member

Somehow drone reported the wrong status here - this is the correct one and it is green: https://drone.nextcloud.com/nextcloud/server/6339

@MorrisJobke MorrisJobke merged commit b9ca121 into nextcloud:stable13 Apr 6, 2018
@JaredBoone JaredBoone deleted the bugfix/8387 branch April 6, 2018 18:11
@MorrisJobke MorrisJobke mentioned this pull request Apr 18, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants