Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix user selectable text for public links for text files #9230

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

MorrisJobke
Copy link
Member

Backport of #9206

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Apr 18, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 13.0.2 milestone Apr 18, 2018
@MorrisJobke MorrisJobke mentioned this pull request Apr 18, 2018
11 tasks
@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #9230 into stable13 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable13    #9230      +/-   ##
==============================================
+ Coverage       51.33%   51.34%   +<.01%     
  Complexity      25040    25040              
==============================================
  Files            1609     1609              
  Lines           95317    95317              
  Branches         1376     1376              
==============================================
+ Hits            48929    48936       +7     
+ Misses          46388    46381       -7
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
core/js/js.js 66.29% <0%> (+0.55%) 0% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Note that in stable13 the Text editor app is not used for text previews (although that would change if nextcloud/files_texteditor#71 was backported), so in this branch this change (currently) affects only the default text preview.

@danxuliu danxuliu merged commit 807955c into stable13 Apr 18, 2018
@danxuliu danxuliu deleted the 13-9206 branch April 18, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants