Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better dav display names #936

Merged
merged 2 commits into from
Aug 24, 2016
Merged

Better dav display names #936

merged 2 commits into from
Aug 24, 2016

Conversation

nickvergessen
Copy link
Member

Before

calendar(uid)

  • missing space before the brackets?
  • uid instead of display name

After

calendar (display name)

Ref https://help.nextcloud.com/t/ok-to-use-username-in-all-big-caps-with-nextcloud/2309/4

@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Aug 18, 2016
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @tcitworld and @PVince81 to be potential reviewers

@LukasReschke
Copy link
Member

PHP Fatal error: Access level to OCA\DAV\Tests\unit\DAV\Migration\ClassificationTest::$userManager must be protected (as in class OCA\DAV\Tests\unit\CalDAV\AbstractCalDavBackendTest) or weaker in /drone/src/github.com/nextcloud/server/apps/dav/tests/unit/Migration/ClassificationTest.php on line 37

@LukasReschke LukasReschke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 18, 2016
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 18, 2016
@nickvergessen
Copy link
Member Author

Test files depending on each others 🙈

@rullzer
Copy link
Member

rullzer commented Aug 24, 2016

Rebased so cal/card dav tests can run again

@rullzer
Copy link
Member

rullzer commented Aug 24, 2016

Mmmm so does this break syncing? Because the name can change?

@nickvergessen
Copy link
Member Author

Mmmm so does this break syncing? Because the name can change?

The URI stays the same, only the display name changes. I didn't experience any problems

@rullzer
Copy link
Member

rullzer commented Aug 24, 2016

Right. Seems davdroid agress with you ;)
👍

@LukasReschke
Copy link
Member

👍

@LukasReschke LukasReschke merged commit b124647 into master Aug 24, 2016
@LukasReschke LukasReschke deleted the better-dav-display-names branch August 24, 2016 11:46
@nickvergessen nickvergessen mentioned this pull request Aug 29, 2016
Merged
@tcitworld tcitworld mentioned this pull request May 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: dav
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @mention-bot @LukasReschke @rullzer