Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stop using Symfony event dispatcher directly #10078

Merged
merged 3 commits into from
Aug 4, 2023
Merged

fix: Stop using Symfony event dispatcher directly #10078

merged 3 commits into from
Aug 4, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 28, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Bildschirmfoto vom 2023-08-04 14-42-07 Bildschirmfoto vom 2023-08-04 14-41-49

🏁 Checklist

@nickvergessen nickvergessen added this to the 💜 Next Major (28) milestone Jul 28, 2023
@nickvergessen nickvergessen self-assigned this Jul 28, 2023
@nickvergessen nickvergessen marked this pull request as draft July 28, 2023 16:28
@nickvergessen nickvergessen force-pushed the techdebt/noid/prepare-28-event-dispatcher branch from 78cbfd3 to fc38ebe Compare July 28, 2023 16:48
@nickvergessen
fix: Stop using Symfony event dispatcher directly
b57f32b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/prepare-28-event-dispatcher branch from fc38ebe to b57f32b Compare August 4, 2023 12:41
@nickvergessen
fix(CI): Bump nextcloud/ocp package for psalm
a53655f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review August 4, 2023 12:48
Antreesy
Antreesy approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@nickvergessen
fix(CI): Update psalm baseline
982df1c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Aug 4, 2023
Merged
@nickvergessen
Copy link
Member Author

Guest app fails due to: nextcloud/guests#1045

@nickvergessen nickvergessen merged commit c888ea9 into master Aug 4, 2023
28 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/prepare-28-event-dispatcher branch August 4, 2023 13:55
@nickvergessen nickvergessen mentioned this pull request Aug 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review technical debt
Projects
💬 Talk team
Archived in project
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy