-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(email): Recognize guests invited via email #13499
base: main
Are you sure you want to change the base?
Conversation
c2c1274
to
a673b3a
Compare
427e9fc
to
8a8f9b6
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
a81cdfb
to
ed01b27
Compare
For quick test without receiving actual e-mail: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with inviting, banning, chatting
); | ||
$this->talkSession->renewSessionId(); | ||
$this->talkSession->setAuthedEmailActorIdForRoom($token, $actorId); | ||
} catch (RoomNotFoundException) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Banned emails are also redirected as 404 to login page, that's what we want for now?
$email, | ||
$accessToken, | ||
); | ||
} | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same link without queries works as public room, but that's for step 2, I guess
Tested ✅ |
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
actorType = Attendee::ACTOR_GUEST
while it should beparticipantType = Participant::GUEST || participantType = Participant::GUEST_MODERATOR
?🏁 Checklist
docs/
has been updated or is not required