feat(chat): add download link to attachments #13618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
|
/backport to stable30 |
DorraJaouad
reviewed
Oct 23, 2024
Comment on lines
+111
to
+116
| <NcActionLink :href="linkToFile"> | ||
| <template #icon> | ||
| <File :size="20" /> | ||
| </template> | ||
| {{ t('spreed', 'Go to file') }} | ||
| </NcActionLink> |
There was a problem hiding this comment.
This wasn't supposed to be shown for guests, no 🤔 ?
There was a problem hiding this comment.
Is wasn't shown, but I don't think it wasn't supposed to. It was a bug.
There was no link in the menu, but the preview itself is a link anyway.
There was a problem hiding this comment.
Shared files in public rooms are public shares, so should be correct here to have access for guests:
- as user:
https://nextcloud.local/index.php/f/585 - as guest:
https://nextcloud.local/index.php/s/A4ERJc3xMKmN88o
Antreesy
approved these changes
Oct 23, 2024
Comment on lines
+463
to
+468
| const uid = getCurrentUser()?.uid | ||
| if (!uid) { | ||
| const fileid = this.linkToFile.slice(this.linkToFile.lastIndexOf('/') + 1) | ||
| return this.messageFile.link + '/download/' + encodeURI(fileid) | ||
| } | ||
| return davRemoteURL + '/files/' + encodeURI(uid) + '/' + encodeURI(this.messageFile.path) |
There was a problem hiding this comment.
Maybe we'll move it to utils/fileDownload.ts? Feels like a fit to keep reusable logic there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist