-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(autoloader): Force own autoloader #8578
Conversation
Server and this app have authorative autoloaders. But I think the generic autoloader in server tries to load this app's files before the shipped autoloader gets a change. If the generic autoloader isn't registered the shipped autoloader gets a chance to load the file. |
Thanks, I was always tempted to add one, but I disliked the "ah forgot to run |
that means |
And don't register any generic PSR-4 nor PSR-0 loader in server. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
…the app Signed-off-by: Joas Schilling <coding@schilljs.com>
398ee88
to
a2d87ad
Compare
Right, it was run only after the app was enabled. |
Tip: nextcloud/mail#8020 to relax the autoloader on dev setups and make it find new files too |
And don't register any generic PSR-4 nor PSR-0 loader in server.
https://github.com/nextcloud/server/blob/473c546b5c562e19ba8f9d3aef9cd64d2458cda7/lib/private/legacy/OC_App.php#L284-L290
Benchmarks
Blackfire comparison graph on IO wait
Blackfire recommendations before
Blackfire recommendations after
🖼️ Screenshots
🏁 Checklist
docs/
has been updated or is not required