Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous Voice recording #1786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Continuous Voice recording #1786

wants to merge 1 commit into from

Conversation

rapterjet2004
Copy link

@rapterjet2004 rapterjet2004 commented Aug 30, 2024 •
edited
Loading

Current Demo

issue-618-1.mov

ToDo

  • Added a voice recording lock button
  • Added a new SwiftUI View for expanded voice recording
  • Stop AVAudioRecorder from ending and implement the send, delete, stop/restart buttons
  • Figure out how to deal with layout changes on orientation and with keyboard,

@rapterjet2004 rapterjet2004 self-assigned this Aug 30, 2024
@rapterjet2004 rapterjet2004 marked this pull request as ready for review September 6, 2024 15:12
SystemKeeper

This comment was marked as resolved.

Sign in to view

@SystemKeeper
Copy link
Collaborator

Really nice work otherwise, thanks a lot 👍

Ivansss

This comment was marked as resolved.

Sign in to view

@SystemKeeper

This comment was marked as outdated.

Sign in to view
@SystemKeeper
Copy link
Collaborator

but maybe something like this is what you want to achieve?

You can do a similar thing for left and right anchor as well, if you don't like the visual layout format.

@rapterjet2004
WIP Continous Voice recording
2572679 
- Added a voice recording lock button
- Added a new SwiftUI View for expanded voice recording

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@Ivansss Ivansss Awaiting requested review from Ivansss

Requested changes must be addressed to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting rid of the need to keep the record button pressed for voice messages
3 participants
@rapterjet2004 @SystemKeeper @Ivansss