Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error message when voice message upload fails #1825

Merged

Conversation

DanielStandfest
Copy link
Contributor

Added logic to display an error message when the upload of a voice message fails due to missing user storage quota.

Fixes #741

@crustulumtheoneandonly
@SystemKeeper

@SystemKeeper
Copy link
Collaborator

Hello and welcome 👋
Thank you very much for your PR! This looks fine - the only thing is that the code you changed (and the part before) uses tabs, instead of spaces. Since the file is otherwise using completely using spaces, would you be able to change that? 😃

Added logic to display an appropriate error message when the upload of a voice message fails. This ensures that users are properly informed about upload issues instead of facing silent failures.

Fixes nextcloud#741

Signed-off-by: Daniel Standfest <daniel@standfest.io>
@DanielStandfest
Copy link
Contributor Author

Hi, thank you.
I didn't recognize it at first.
It should be fixed now.

Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your PR @DanielStandfest :)

Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@SystemKeeper SystemKeeper merged commit 48e7772 into nextcloud:master Oct 11, 2024
11 checks passed
@DanielStandfest DanielStandfest deleted the error-on-voice-upload-fail branch October 11, 2024 21:30
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errormessage missing when voicemessage upload fails
3 participants