Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostics #829

Merged
merged 11 commits into from
Jul 1, 2022
Merged

Diagnostics #829

merged 11 commits into from
Jul 1, 2022

Conversation

SystemKeeper
Copy link
Collaborator

Add some simple diagnostic information to the settings:

image

image

image

image

@SystemKeeper SystemKeeper mentioned this pull request Jun 21, 2022
Open
14 tasks
@SystemKeeper
Copy link
Collaborator Author

image

@SystemKeeper SystemKeeper mentioned this pull request Jun 21, 2022
Merged
@vitormattos vitormattos requested a review from Ivansss June 24, 2022 20:09
@SystemKeeper
Copy link
Collaborator Author

image

@SystemKeeper
Copy link
Collaborator Author

  • Show capabilities when talk server version is not available (Talk < 15)
  • Removed internal signaling api (can be optained through capabilities)
  • Added todo in Ideas for additional diagnostics #830 for adding external signaling version.

image

image

@SystemKeeper
Add diagnostics section to settings
654dda3 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Fix typo
6c3a9af 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Remove force casts
d32c4ed 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Add title for diagnostics section
fd8334b 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Show talk server version when available
c3b59ed 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Simplified titles for header
f2c5c6c 
Show capabilities if talk server version is not available
Removed internal signaling version

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Copy link
Collaborator Author

image

image

@SystemKeeper
Add external signaling version
f63c8e2 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
Update Localizable
8b1a9d2 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@Ivansss
Fix some SwiftLint warnings and errors.
dc3fcae 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Use "Not requested" instead of "Unknown".
83bc44a 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Update localizable strings file.
19e76d0 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss merged commit a07e949 into master Jul 1, 2022
@Ivansss Ivansss deleted the diagnostics branch July 1, 2022 11:54
@AndyXheli AndyXheli mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SystemKeeper @Ivansss