Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent editing not public tasks in lists shared with me #862

Merged
merged 2 commits into from
Feb 17, 2020

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented Feb 10, 2020

This PR fixes #467 and implements #819 and #821.

Editing tasks in a calendar shared with me which have an access class other than PUBLIC is not possible anymore. Also changing the access class for tasks in a calendar shared with me will be prevented.

However, this only fixes the problem on the client side. Editing such tasks still needs to be prevented on the server side as well, see nextcloud/server#5551.

As a side effect, since we have to load the current user principal for this, we now show user avatars for the owner of a calendar shared with me in the app-navigation list and allow to unshare a calendar.

@rkaraba you might want to have a look as well.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #862 into master will decrease coverage by 0.96%.
The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
- Coverage   31.92%   30.95%   -0.97%     
==========================================
  Files          23       25       +2     
  Lines        1253     1305      +52     
  Branches      223      235      +12     
==========================================
+ Hits          400      404       +4     
- Misses        729      766      +37     
- Partials      124      135      +11

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Member Author

@georgehrke How should we handle deleting non-public tasks/events in calendars shared with me? Do you plan to allow or forbid this in server? In this PR I treat such tasks as read-only, so deleting is not possible. But I would like to implement it the same way as in server.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Member Author

@georgehrke Ping.

@georgehrke
Copy link
Member

@raimund-schluessler Yes, my plan for the server is to forbid editing / deleting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants