Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User session might be persisted #3848

Closed
juliusknorr opened this issue Feb 28, 2023 · 0 comments · Fixed by #3946
Closed

User session might be persisted #3848

juliusknorr opened this issue Feb 28, 2023 · 0 comments · Fixed by #3946
Labels
1. to develop 26 feedback bug Something isn't working high

Comments

@juliusknorr
Copy link
Member

https://github.com/nextcloud/text/blob/main/lib/Controller/SessionController.php#L110 should get reset after controller method calls that make use of it as otherwise this may load to the current session getting updated with a different user.

I've seen this happening locally with:

  • tab 1: Having a tab open with a text editor
  • tab 2: Logout in a second tab
  • tab 2: Login as a different user
  • tab 2: Navigate to another page
  • tab 2: See that you're logged in as the previous user
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Feb 28, 2023
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Mar 10, 2023
@juliusknorr juliusknorr mentioned this issue Mar 15, 2023
Merged
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop 26 feedback bug Something isn't working high
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure to not persist user put into the session for direct editing nextcloud/text
1 participant
@juliusknorr