Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure to not persist user put into the session for direct editing #3946

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix: Ensure to not persist user put into the session for direct editing #3946

merged 1 commit into from
Mar 17, 2023

Conversation

juliusknorr
Copy link
Member

Fixes #3848

@juliusknorr juliusknorr mentioned this pull request Mar 15, 2023
Closed
9 tasks
marcelklehr
marcelklehr approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@cypress
Copy link

cypress bot commented Mar 15, 2023 •
edited
Loading

Passing run #9067 ↗︎

0 136 1 0 Flakiness 0

Details:

fix: Ensure to not persist user put into the session for direct editing
Project: Text Commit: f97a58735a
Status: Passed Duration: 04:40 💡
Started: Mar 15, 2023 5:35 PM Ended: Mar 15, 2023 5:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
fix: Ensure to not persist user put into the session for direct editing
f97a587 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/user-session-restore branch from 5d74bad to f97a587 Compare March 15, 2023 14:13
@juliusknorr juliusknorr merged commit 3b9f353 into main Mar 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/user-session-restore branch March 17, 2023 11:55
@juliusknorr juliusknorr added bug Something isn't working backport-request labels Mar 17, 2023
@juliusknorr
Copy link
Member Author

/backport to stable26

@juliusknorr
Copy link
Member Author

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 28, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 28, 2023
Merged
1 task
@sascha-wi
Copy link

sascha-wi commented May 31, 2023 •
edited
Loading

How do I know if this issue will also be fixed in v24? Or is v24 not affected at all by this?

@HumBelele
Copy link

How do I know if this issue will also be fixed in v24? Or is v24 not affected at all by this?

NC 24 is out of active Support. So no further Updates for Version 24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User session might be persisted
4 participants
@juliusknorr @sascha-wi @HumBelele @marcelklehr