Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mentions extra spaces #6314

Closed
kaffeeringe opened this issue Jul 25, 2024 · 6 comments · Fixed by #6315
Closed

mentions extra spaces #6314

kaffeeringe opened this issue Jul 25, 2024 · 6 comments · Fixed by #6315
Labels
bug Something isn't working

Comments

@kaffeeringe
Copy link

kaffeeringe commented Jul 25, 2024

Describe the bug
There are extra spaces in between mentions after I save

To Reproduce
Steps to reproduce the behavior:

  1. Add a row of mentions
  2. Save the page
  3. There are extra spaces in between the mentions

Expected behavior
No extra spaces

Screenshots
Screenshot Nextcloud
I only added one space in between the mentions. You see, there are several.

Server details:

  • Nextcloud version: 29.0.4
@kaffeeringe kaffeeringe added the bug Something isn't working label Jul 25, 2024
@joshtrichards
Copy link
Member

Hmm. I can't reproduce this behavior. When autocomplete fills in the rest of the mentioned user, there is already a space added automatically. Are you sure it's not that that you're doubling on by manually adding a space yourself?

@mejo-
Copy link
Member

mejo- commented Aug 5, 2024

Indeed, adding mentions (and also emojis) already adds a space afterwards so you don't have to type one manually. Probably that's what you experience @kaffeeringe, no?

@kaffeeringe
Copy link
Author

Strange. I struggled a few times with this. But I can't reproduce it anymore...

@mejo-
Copy link
Member

mejo- commented Aug 5, 2024

Thanks for checking again @kaffeeringe. Let's close the issue for now, but feel free to comment and reopen if you run into this again.

@mejo- mejo- closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
@kaffeeringe
Copy link
Author

No, wait! This seems to happen only in Collectives! And only while editing.

When I add @name1, @name2 and save that it looks ok. But when I edit it, it adds another space. When I save it again, it's gone again.

@mejo- mejo- reopened this Aug 5, 2024
@mejo- mejo- transferred this issue from nextcloud/text Aug 5, 2024
@mejo- mejo- transferred this issue from nextcloud/collectives Sep 4, 2024
mejo- added a commit that referenced this issue Sep 4, 2024
Fixes: #6314

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member

mejo- commented Sep 4, 2024

This is reproducible on Text. The problem is that we always surround mentions with whitespaces when serializing them to markdown. I think that's wrong. Will open a PR to fix this.

mejo- added a commit that referenced this issue Sep 5, 2024
Fixes: #6314

Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot pushed a commit that referenced this issue Sep 5, 2024
Fixes: #6314

Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot pushed a commit that referenced this issue Sep 5, 2024
Fixes: #6314

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants