Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicly shared .md files: Outline has no background on mobile #6693

Closed
jacobseated opened this issue Nov 25, 2024 · 1 comment · Fixed by #6728
Closed

Publicly shared .md files: Outline has no background on mobile #6693

jacobseated opened this issue Nov 25, 2024 · 1 comment · Fixed by #6728
Assignees
Labels
bug Something isn't working

Comments

@jacobseated
Copy link

jacobseated commented Nov 25, 2024

Describe the bug
Outline has no background, which results in unreadable overlapping text on mobile for .md notes that are shared publicly. The links in the document outline simply overlaps the text in the .md file.

To Reproduce
Steps to reproduce the behavior:

  • Open any shared note externally on mobile.
  • Open any shared note on a browser and resize the window

Expected behavior
I assume the text should have a background, and at least some basic styling to make it look "not broken".

The following is a quick and dirty fix I applied in a custom app, because even the use of white space was quite ugly:

.editor-media-handler .text-editor--readonly-bar .text-readonly-bar {
  background-color: var(--color-main-background);
  padding:0.5rem 0;
}
.text-editor__content-wrapper .text-editor__content-wrapper__left .editor--outline {
  min-width: 300px;
  width: auto; /* This is still not enough to show whole text lines */
  margin:0 auto;
  background-color: var(--color-main-background);
  padding: 0;
  margin: 0 0.5rem;
  border-radius: 0.5rem;
  z-index: 900;
  border:1px solid var(--vs-border-color);
}
.editor--toc {
  padding:0 0.5rem;
}
.editor--outline li {
  padding: 0.25rem 0;
}
.text-editor__session-list .session-list .avatar-list .avatar-wrapper {
  margin: 0.2rem 0.1rem 0;
  width: 1.5rem;
  height: 1.5rem;
}
@jacobseated jacobseated added the bug Something isn't working label Nov 25, 2024
@mejo-
Copy link
Member

mejo- commented Dec 3, 2024

Thanks for your report. I was able to reproduce, a fix is incoming.

@mejo- mejo- self-assigned this Dec 3, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 3, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Dec 3, 2024
mejo- added a commit that referenced this issue Dec 3, 2024
Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Dec 5, 2024
backportbot bot pushed a commit that referenced this issue Dec 5, 2024
Also enable outline on mobile in read-write mode.

Fixes: #6410

Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>

[skip ci]
backportbot bot pushed a commit that referenced this issue Dec 5, 2024
Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 10, 2024
Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
juliusknorr pushed a commit that referenced this issue Dec 12, 2024
Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
juliusknorr pushed a commit that referenced this issue Dec 13, 2024
Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
juliusknorr pushed a commit that referenced this issue Dec 17, 2024
Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 17, 2024
Also enable outline on mobile in read-write mode.

Fixes: #6410
Fixes: #6693

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ☑️ Done
Development

Successfully merging a pull request may close this issue.

2 participants