[stable24] Fix attachment cleanup when file names contain parenthesis #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/compile amend |
nextcloud-command
force-pushed
the
backport/2383/stable24/attachment-cleanup-get-names-2
branch
from
8893dda to
15fd8a9
Compare
mejo-
reviewed
May 13, 2022
tests/.phpunit.result.cache
Outdated
| @@ -0,0 +1 @@ | |||
| {"version":1,"defects":[],"times":{"OCA\\Text\\Tests\\TextTest::testDummy":0.001,"OCA\\Text\\Tests\\TextTest::testGetAttachmentNamesFromContent":0.002}} | |||
tests/clover.xml
Outdated
| @@ -0,0 +1,1461 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Is this file pushed on purpose? Looks like a coverage report that is probably subject to change with each code change, no?
julien-nc
force-pushed
the
backport/2383/stable24/attachment-cleanup-get-names-2
branch
from
15fd8a9 to
5a2ecce
Compare
|
/compile amend |
|
@mejo- Nice catch, thanks. We need to add some entries to the gitignore file 😁 |
… also fixes cleanup when there are parenthesis in the file names Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/2383/stable24/attachment-cleanup-get-names-2
branch
from
5a2ecce to
934893d
Compare
mejo-
approved these changes
May 13, 2022
delete-merged-branch
bot
deleted the
backport/2383/stable24/attachment-cleanup-get-names-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #2383