Improve Header bar #2441
Merged
Improve Header bar #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinicius73
reviewed
May 24, 2022
luka-nextcloud
force-pushed
the
feature/2440-improve-header-bar
branch
from
5af4375 to
e94308d
Compare
18 tasks
|
Before/after screenshots would be great for quick design review @luka-nextcloud @vinicius73 :) thanks! |
@jancborchardt Please check the following screenshots. Before: After: |
luka-nextcloud
force-pushed
the
feature/2440-improve-header-bar
branch
from
e94308d to
af81b2e
Compare
luka-nextcloud
force-pushed
the
feature/2440-improve-header-bar
branch
from
af81b2e to
79284bc
Compare
|
/rebase |
nextcloud-command
force-pushed
the
feature/2440-improve-header-bar
branch
from
79284bc to
d57c620
Compare
luka-nextcloud
force-pushed
the
feature/2440-improve-header-bar
branch
2 times, most recently
from
b243c4d to
d2cdf75
Compare
|
/rebase |
nextcloud-command
force-pushed
the
feature/2440-improve-header-bar
branch
from
d2cdf75 to
3bcf161
Compare
juliusknorr
requested changes
Jul 19, 2022
There was a problem hiding this comment.
@vinicius73 Let's wait for the merge of the viewer PR, as this one then needs to be adjusted to use the data attribute.
luka-nextcloud
force-pushed
the
feature/2440-improve-header-bar
branch
from
3bcf161 to
f507878
Compare
juliusknorr
approved these changes
Jul 20, 2022
|
/compile amend / |
Signed-off-by: Luka Trovic <luka@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
feature/2440-improve-header-bar
branch
from
f507878 to
0b130d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
Some improvements on the header bar.