Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rich workspace visibility #3291

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Oct 21, 2022

@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Nov 9, 2022
@luka-nextcloud luka-nextcloud force-pushed the feature/rich-workspace-visibility branch from 37532f7 to c641b65 Compare November 29, 2022 14:01
@luka-nextcloud luka-nextcloud changed the title <WIP> Update rich workspace visibility Update rich workspace visibility Nov 29, 2022
@cypress
Copy link

cypress bot commented Nov 29, 2022

Passing run #8435 ↗︎

0 132 0 0 Flakiness 0

Details:

Update rich workspace visibility
Project: Text Commit: 79092a978b
Status: Passed Duration: 03:26 💡
Started: Feb 2, 2023 3:36 PM Ended: Feb 2, 2023 3:40 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
@luka-nextcloud luka-nextcloud force-pushed the feature/rich-workspace-visibility branch 2 times, most recently from 1d4d2e5 to cac9965 Compare December 26, 2022 15:22
@luka-nextcloud luka-nextcloud force-pushed the feature/rich-workspace-visibility branch 2 times, most recently from 2663fb1 to 17b044e Compare January 20, 2023 08:55
@juliusknorr
Copy link
Member

@luka-nextcloud Server pr was merged, so rebasing should run cypress against the latest server master branch.

@luka-nextcloud luka-nextcloud force-pushed the feature/rich-workspace-visibility branch from 17b044e to d1b0bff Compare January 31, 2023 10:25
cypress/e2e/workspace.spec.js Outdated Show resolved Hide resolved
cypress/e2e/workspace.spec.js Outdated Show resolved Hide resolved
cypress/support/commands.js Outdated Show resolved Hide resolved
cypress/support/commands.js Outdated Show resolved Hide resolved
src/helpers/files.js Outdated Show resolved Hide resolved
src/helpers/files.js Show resolved Hide resolved
@juliusknorr juliusknorr requested review from max-nextcloud and removed request for vinicius73 January 31, 2023 11:50
@juliusknorr juliusknorr force-pushed the feature/rich-workspace-visibility branch from d1b0bff to 0f94194 Compare February 1, 2023 13:39
@juliusknorr
Copy link
Member

@luka-nextcloud Cypress tests seem good now, can you remove the remaining force parts in the spec files and fix the eslint errors?

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the feature/rich-workspace-visibility branch from d274708 to 4d2f4fe Compare February 2, 2023 15:14
@juliusknorr
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 1382ad7 into main Feb 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/rich-workspace-visibility branch February 2, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich workspaces: If there is no Readme.md, don’t show editor placeholder but move into "+" menu
3 participants