Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Bring back menubar without formatting on plain text mode #3475

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

max-nextcloud
Copy link
Collaborator

๐Ÿ“ Summary

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before ๐Ÿก After
Bildschirmfoto vom 2022-11-23 08-45-16 Bildschirmfoto vom 2022-11-23 08-44-36

๐Ÿ Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Not really a backport but rather a reimplementation of #2757.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@cypress
Copy link

cypress bot commented Nov 23, 2022



Test summary

51 โ€ข 0 โ€ข 0 โ€ข 0


Run details

Project Text
Status Passed
Commit b60721e โ„น๏ธ
Started Nov 23, 2022 8:00 AM
Ended Nov 23, 2022 8:03 AM
Duration 02:47 ๐Ÿ’ก
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard โžก๏ธ


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@max-nextcloud
Copy link
Collaborator Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud requested a review from mejo- November 23, 2022 11:47
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good codewise. I haven't tested myself, but probably you have tested it aleady :)

@max-nextcloud max-nextcloud merged commit a8dda86 into stable24 Nov 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/2757/stable24 branch November 23, 2022 13:15
@blizzz blizzz mentioned this pull request Nov 23, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants