-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix direct editing loading of txt files #3476
Conversation
@max-nextcloud those were the changes from our earlier debugging session. Will add a cypress test later for this as well. |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I also figured out why the session id is being regenerated. It seems that the user id is now written to the session (which was not before 25) due to the fact that we change into the user scope. First attempt to properly address this is in nextcloud/server#35360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minimal change, hopefully easy to backport to 25.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
0ebd6e9
to
ca98523
Compare
/compile |
/backport to stable25 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
The backport to stable25 failed. Please do this backport manually. |
📝 Summary
Fix loading txt files through direct editing
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)