Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direct editing loading of txt files #3476

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 23, 2022

📝 Summary

Fix loading txt files through direct editing

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr
Copy link
Member Author

@max-nextcloud those were the changes from our earlier debugging session. Will add a cypress test later for this as well.

@juliusknorr juliusknorr added 2. developing bug Something isn't working labels Nov 23, 2022
@cypress
Copy link

cypress bot commented Nov 23, 2022



Test summary

108 0 0 0Flakiness 1


Run details

Project Text
Status Passed
Commit 341b912 ℹ️
Started Nov 23, 2022 2:28 PM
Ended Nov 23, 2022 2:35 PM
Duration 06:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/links.spec.js Flakiness
1 test link marks > link preview > shows a link preview

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@juliusknorr
Copy link
Member Author

I also figured out why the session id is being regenerated. It seems that the user id is now written to the session (which was not before 25) due to the fact that we change into the user scope. First attempt to properly address this is in nextcloud/server#35360

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minimal change, hopefully easy to backport to 25.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

/compile

@juliusknorr
Copy link
Member Author

/backport to stable25

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress
Copy link

cypress bot commented Nov 23, 2022



Test summary

108 0 0 0Flakiness 2


Run details

Project Text
Status Passed
Commit 513e07e
Started Nov 23, 2022 2:51 PM
Ended Nov 23, 2022 2:58 PM
Duration 07:12 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Flakiness

links.spec.js Flakiness
1 test link marks > link preview > shows a link preview
sections.spec.js Flakiness
1 Content Sections > Heading anchors > Anchor scrolls into view

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@juliusknorr juliusknorr merged commit 3ccb2ac into master Nov 23, 2022
@juliusknorr juliusknorr deleted the bugfix/noid/txt-direct branch November 23, 2022 14:59
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Nov 23, 2022

/backport e5f773b, ca98523 to stable25

1 similar comment
@max-nextcloud
Copy link
Collaborator

/backport e5f773b, ca98523 to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants