fix: Properly emit ready event on conflicts with the editor API #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 flaky tests on run #9392 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
share.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
Also fixes this issue on Collectives as there the parent component is the |
|
/backport to stable26 |
mejo-
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks for tackeling this @juliushaertl. Code looks good to me 👍
juliusknorr
force-pushed
the
bugfix/noid/event-api
branch
from
9ae3314 to
c5386b2
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
mejo-
force-pushed
the
bugfix/noid/event-api
branch
from
c5386b2 to
94160a9
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes loading the editor integrated through the editor API when a file conflict occurs during the initial loading. In this case the ready event was never emitted on the root component that would pass the state to the notes app.
I'd love to have a more generic way there but haven't found a proper way to avoid emitting on both this and parent, so the second commit cleans up the emit handling in Editor.vue to make sure we always emit on both.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)