Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expect HTML element with ID mimetype in public share #4253

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jun 7, 2023

If the share is password-protected, the authentication page doesn't have the property set yet.

Fixes: #3816

If the share is password-protected, the authentication page doesn't have
the property set yet.

Fixes: #3816

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added bug Something isn't working 3. to review labels Jun 7, 2023
@cypress
Copy link

cypress bot commented Jun 7, 2023

1 failed and 2 flaky tests on run #10027 ↗︎

1 138 1 3 Flakiness 2

Details:

Don't expect HTML element with ID `mimetype` in public share
Project: Text Commit: 09845de7de
Status: Failed Duration: 03:56 💡
Started: Jun 7, 2023 6:06 PM Ended: Jun 7, 2023 6:10 PM
Failed  cypress/e2e/viewer.spec.js • 1 failed test

View Output Video

Test Artifacts
Open test.md in viewer > See test.md in the list Output Screenshots
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  conflict.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > resolves conflict using current editing session Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-
Copy link
Member Author

mejo- commented Jun 7, 2023

/backport to stable27

@mejo-
Copy link
Member Author

mejo- commented Jun 7, 2023

/backport to stable26

@mejo-
Copy link
Member Author

mejo- commented Jun 7, 2023

/backport to stable25

@mejo-
Copy link
Member Author

mejo- commented Jun 7, 2023

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit 2b4bd39 into main Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/public_share_auth branch June 7, 2023 19:09
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin/stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member Author

mejo- commented Jun 7, 2023

/backport 4f17eee to stable27

@mejo-
Copy link
Member Author

mejo- commented Jun 7, 2023

/backport 4f17eee to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mejo-
Copy link
Member Author

mejo- commented Jun 7, 2023

/backport 4f17eee to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error on public share auth page
3 participants