-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): info callout box color to --color-info #4301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback to the hard coded value for our primary element default. `--color-info` was only introduced with Nextcloud 27. Signed-off-by: Max <max@nextcloud.com>
/backport c564511 to stable27 |
/backport c564511 to stable26 |
/backport c564511 to stable25 |
/compile |
mejo-
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for tackling this!
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 failed and 1 flaky tests on run #10190 ↗︎
Details:
sync.spec.js • 1 failed test
viewer.spec.js • 1 failed test
cypress/e2e/api/UsersApi.spec.js • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
This was referenced Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fallback to the hard coded value for our primary element default.
--color-info
was only introduced with Nextcloud 27.info
changes color with theme #4161🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)