Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): info callout box color to --color-info #4301

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

Fallback to the hard coded value for our primary element default. --color-info was only introduced with Nextcloud 27.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • no tests as we do not test css styles (yet).
  • Documentation is not required

Fallback to the hard coded value for our primary element default.
`--color-info` was only introduced with Nextcloud 27.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud added bug Something isn't working 3. to review ux labels Jun 16, 2023
@max-nextcloud
Copy link
Collaborator Author

/backport c564511 to stable27

@max-nextcloud
Copy link
Collaborator Author

/backport c564511 to stable26

@max-nextcloud
Copy link
Collaborator Author

/backport c564511 to stable25

@max-nextcloud
Copy link
Collaborator Author

/compile

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this!

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress
Copy link

cypress bot commented Jun 16, 2023

2 failed and 1 flaky tests on run #10190 ↗︎

2 142 1 3 Flakiness 1

Details:

fix(css): info callout box color to --color-info
Project: Text Commit: d8acca5e18
Status: Failed Duration: 03:44 💡
Started: Jun 16, 2023 6:03 PM Ended: Jun 16, 2023 6:07 PM
Failed  sync.spec.js • 1 failed test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Failed  viewer.spec.js • 1 failed test

View Output Video

Test Artifacts
Open test.md in viewer > See test.md in the list Output Screenshots
Flakiness  cypress/e2e/api/UsersApi.spec.js • 1 flaky test

View Output Video

Test Artifacts
The user mention API > fetches users with valid session Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callout box with type info changes color with theme
3 participants