Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] test(cy): skip test failing due to server issue #5145

Merged
merged 6 commits into from
Dec 21, 2023
Merged

[stable28] test(cy): skip test failing due to server issue #5145

merged 6 commits into from
Dec 21, 2023

Commits on Dec 21, 2023

  1. test(cy): skip test failing due to server issue 

    nextcloud/server#42306
causes the DELETE request to fail with 423 Locked.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1cc4ef3 View commit details
    Browse the repository at this point in the history

  2. test(cy): simplify requesttoken handling 

    * Use `this.requesttoken` rather than `cy.get(@requesttoken)`
  to use the same value rather than re-evaluating the query.
* After visit `this.requesttoken` will be set.
  No need to attempt to load the token from the window
  if it is not.
* Use a simple `if` statement instead of `cypress-if`.
* This also cleans up the cypress logs significantly.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    2c8e226 View commit details
    Browse the repository at this point in the history

  3. fix(cy): attachment spec share test 

    * call `cy.showHiddenfiles()` before loading the page.
* Clear `requesttoken` in `cy.login()`.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    8268961 View commit details
    Browse the repository at this point in the history

  4. test(cy): silence cy.window 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e9f2957 View commit details
    Browse the repository at this point in the history

  5. chore(ci): use current upload-artifact action 

    Fix the warning in CI.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c83beee View commit details
    Browse the repository at this point in the history

  6. test(ci): upload nextcloud.log to different files 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ee99bc1 View commit details
    Browse the repository at this point in the history