Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] Fix cypress workspace test by setting default language #5146

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5143

Some tests modify it - so set it to `en` in `beforeEach`.

Following the recommendataion of preparing everything
in `beforeEach` hooks
rather then reverting the changes in `after` hooks
so the state of failing tests can be inspected.

Signed-off-by: Max <max@nextcloud.com>
* `cy.openWorkspace()` and `cy.createDescription()`
  use the currently opened path now.
  They don't need any argument anymore.
  This also avoids duplicate page loads.
* Use 'testFolder' alias and `this.testFolder`
  instead of `currentFolder` variable.

Signed-off-by: Max <max@nextcloud.com>
Otherwise `this.testFolder` is not available
as `this` cannot be reassigned with arrow functions.

Signed-off-by: Max <max@nextcloud.com>
This was referenced Dec 21, 2023
@juliusknorr juliusknorr merged commit 0fa957d into stable28 Dec 21, 2023
31 of 34 checks passed
@juliusknorr juliusknorr deleted the backport/5143/stable28 branch December 21, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants