Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Preview): hide link bubble when preview menu opens #5445

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

  • Only show link bubble when cursor is inside the link. This way it does not show when opening the preview menu (which moves the cursor to the start of the line).
  • Part of Link preview follow up #5442 .

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@max-nextcloud max-nextcloud mentioned this pull request Mar 7, 2024
11 tasks
@max-nextcloud max-nextcloud force-pushed the fix/hide-bubble-when-in-menu branch from f8be981 to 17a1673 Compare March 12, 2024 15:04
@max-nextcloud max-nextcloud enabled auto-merge March 12, 2024 15:04
@max-nextcloud
Copy link
Collaborator Author

failing tests are related. They expect the bubble to show when cursor is on first char.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the fix/hide-bubble-when-in-menu branch from 17a1673 to 2478693 Compare March 15, 2024 13:44
@max-nextcloud max-nextcloud merged commit 9cf8f1a into main Mar 15, 2024
59 checks passed
@max-nextcloud max-nextcloud deleted the fix/hide-bubble-when-in-menu branch March 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants