fix(sync): If baseVersionEtag changed, reset frontend
#5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/baseversionetag_change
branch
from
2a5117c to
e186a56
Compare
mejo-
force-pushed
the
fix/5476/document-cleanup
branch
from
aee2afa to
a63daee
Compare
mejo-
force-pushed
the
fix/baseversionetag_change
branch
2 times, most recently
from
f787fa4 to
97ee7d5
Compare
`baseVersionEtag` changes when a new document session got initialized, e.g. after an old document session without session clients got cleaned up, or because the markdown file got changed via webdav. Detect this in the client and ask the user to reload the page for resetting the session. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/baseversionetag_change
branch
from
97ee7d5 to
17efed4
Compare
Fixes: #4905 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/baseversionetag_change
branch
from
17efed4 to
aac9123
Compare
max-nextcloud
approved these changes
Mar 20, 2024
Signed-off-by: Jonas <jonas@freesources.org>
…eanup Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/baseversionetag_change
branch
from
9e9288b to
a4e8747
Compare
Wrap error messages into an array when responding with `JSONResponse`. Signed-off-by: Jonas <jonas@freesources.org>
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The PR builds on #5477
baseVersionEtagchanged, reset frontendbaseVersionEtagchanges when a new document session got initialized, e.g. after an old document session without session clients got cleaned up, or because the markdown file got changed via webdav.Detect this in the client and ask the user to reload the page for resetting the session.
baseVersionEtagdoesn't matchNcNoteCardScreenshot
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)