Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paragraph): migrate preview options to decorations #6425

Merged
merged 13 commits into from
Sep 19, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 18, 2024

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

max-nextcloud and others added 6 commits September 18, 2024 13:09
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Render the preview options as a decoration for previews too.

Signed-off-by: Max <max@nextcloud.com>
Fixes: #6185

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Required for implementing `deleteNode` like tiptap does it:
https://github.com/ueberdosis/tiptap/blob/develop/packages/core/src/NodeView.ts#L305

Signed-off-by: Max <max@nextcloud.com>
@mejo- mejo- force-pushed the fix/paragraph-node-view-to-decorations branch from 9a078ec to 93d545f Compare September 18, 2024 11:09
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick.

cypress/e2e/nodes/PreviewOptions.spec.js Outdated Show resolved Hide resolved
@max-nextcloud
Copy link
Collaborator

Oh... did you manage to fix that function that checked if the decorations can be mapped or need to be recomputed?

@mejo- mejo- force-pushed the fix/paragraph-node-view-to-decorations branch from 56ab0e9 to 7628e9f Compare September 18, 2024 16:23
@mejo-
Copy link
Member Author

mejo- commented Sep 18, 2024

/backport to stable30

@mejo-
Copy link
Member Author

mejo- commented Sep 18, 2024

/backport to stable29

max-nextcloud and others added 7 commits September 18, 2024 18:27
Compute the range based on offset and nodeSize.

Signed-off-by: Max <max@nextcloud.com>
- center align options for text links
- top align options for preview links

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Otherwise the overlay container would catch all the click events.

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
* Don't calculate preview options decorations in readonly editor
* Check for changed nodeSize when checking for decoration changes
* Rename `editor` to `$editor` in vue compontent, it's not reactive

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/paragraph-node-view-to-decorations branch from 7628e9f to 5d61e84 Compare September 18, 2024 16:32
@mejo- mejo- merged commit b2c45a9 into main Sep 19, 2024
59 of 61 checks passed
@mejo- mejo- deleted the fix/paragraph-node-view-to-decorations branch September 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

pressing UP on newline goes to line 1, not up one line
2 participants