Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input rule for checkboxes #901

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 22, 2020

  • Allows to convert the current node checkboxes by typing "- [ ]"
  • Fixes some positioning issues compared to regular lists

Peek 2020-12-22 15-44

Before:
image

After:
image

@juliusknorr
Copy link
Member Author

This currently has the side effect that regular lists will only be converted after typing the first character after - , I'm not sure if there is an easy way around that yet.

@juliusknorr juliusknorr force-pushed the bugfix/819/checkbox-input-rule branch from e9976d7 to 39fb229 Compare December 22, 2020 14:23
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, looks good design-wise! :)

Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (Sorry, didn't check the code, but only the screen record)

  • Does it also work if there is a space character between the brackets like - [ ]?
  • Wouldn't it make more sense to replace the graphical checkbox when pressing backspack with the text representation - [ ] instead of removing it completely? At least for me this is the expexted behavior, but i don't insist to keep it, it's just well-known to me.

@rullzer rullzer mentioned this pull request Dec 28, 2020
39 tasks
@juliusknorr juliusknorr merged commit a5c44da into master Dec 28, 2020
@juliusknorr juliusknorr deleted the bugfix/819/checkbox-input-rule branch December 28, 2020 18:21
@juliusknorr
Copy link
Member Author

  • Does it also work if there is a space character between the brackets like - [ ]?

Yes, that is the case.

Wouldn't it make more sense to replace the graphical checkbox when pressing backspack with the text representation - [ ] instead of removing it completely? At least for me this is the expexted behavior, but i don't insist to keep it, it's just well-known to me.

Moved to #1307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance checkbox behavior
3 participants