-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input rule for checkboxes #901
Conversation
This currently has the side effect that regular lists will only be converted after typing the first character after |
e9976d7
to
39fb229
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
39fb229
to
4c6b17b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, looks good design-wise! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! (Sorry, didn't check the code, but only the screen record)
- Does it also work if there is a space character between the brackets like
- [ ]
? - Wouldn't it make more sense to replace the graphical checkbox when pressing backspack with the text representation
- [ ]
instead of removing it completely? At least for me this is the expexted behavior, but i don't insist to keep it, it's just well-known to me.
Yes, that is the case.
Moved to #1307 |
Before:
After: