Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nextcloud 25 and fix static analysis #172

Merged
merged 2 commits into from
May 10, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented May 9, 2022

Signed-off-by: Richard Steinmetz richard@steinmetz.cloud

@st3iny st3iny self-assigned this May 9, 2022
@st3iny st3iny added this to the 0.4.0 milestone May 9, 2022
@st3iny st3iny added the techdebt label May 9, 2022
ChristophWurst
ChristophWurst previously approved these changes May 9, 2022
@st3iny
Copy link
Member Author

st3iny commented May 9, 2022

CI works again 🎉 However, it seems like we have some problems on Nextcloud v21. Aren't we supposed to drop 21 anyways?

@st3iny st3iny requested a review from ChristophWurst May 9, 2022 14:48
@ChristophWurst
Copy link
Member

CI works again tada However, it seems like we have some problems on Nextcloud v21. Aren't we supposed to drop 21 anyways?

We could update the baseline. The missing event class showed with 21 until we made it independent of Symfony with nextcloud/server#25560

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny marked this pull request as ready for review May 10, 2022 07:02
@st3iny st3iny mentioned this pull request May 10, 2022
@ChristophWurst ChristophWurst merged commit af69af2 into main May 10, 2022
@ChristophWurst ChristophWurst deleted the techdebt/noid/fix-ci branch May 10, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants