optional imap groups via domain & make domain striping optional #65

lavdnone · 2019-03-31T04:01:28Z

imap groups via domain-part
for #10 working with v15 from nextcloud/apps@master...bjoern86:patch-1

if someone can convert it to new way "$query->insert..."

Changes proposed in this pull request:

if there is no group equal to domain part of the new user create group
add new user to the group
make group and domain striping configurable via parameters

fixes #10
fixes #76
fixes #68

violoncelloCH · 2019-04-14T15:31:17Z

thank you for the PR!
yes this would need some adaptions for the DB part (sorry I currently don't the time for it)...
also simply adding this to the base.php could cause other problems if someone uses email addresses as usernames or simply usernames with @ s in an other backend... it would at least be needed to check if the backend is IMAP before applying this...

lavdnone · 2019-04-15T07:35:18Z

Updated to getGroupManager()->createGroup from OC_DB

Maybe you can add if backend is IMAP? something like:

if($createduser->getBackendClassName() === 'OC_User_IMAP')
if(get_class($backend) === 'OC_User_IMAP')

violoncelloCH · 2019-05-08T20:02:54Z

cool, thanks!
I'll look into this as soon as I'll find some time...

hmm, we should probably also make this optional, because probably not everyone wants this behaviour and it would be an unexpected change... so having an optional parameter in the configuration that has to be set to true...

violoncelloCH · 2019-05-22T19:26:01Z

looking a little closer at this I noticed that this won't work if if the domain is striped away from the username :/ currently this is only the case if the domain is restricted, however I would like to make it possible to configure all this independently...
so in the end it should also be possible to restrict to multiple domains, stripe the domain (admin would need to make sure there are no username conflicts) but still put users into a group according to the domain...

violoncelloCH · 2019-05-22T21:09:04Z

okay so I've moved this so it's only executed for IMAP... not sure though if it's the best way to do this... (feedback welcome)
I've also added the possibility for two additional parameters whether to stripe the domain part and whether to create a group from the domain or not...
also the generation of the group is not yet working correctly... need to investigate in how this works...

lib/imap.php

violoncelloCH · 2019-05-22T21:43:22Z

also the generation of the group is not yet working correctly... need to investigate in how this works...

found this... 🙈
should be working now

violoncelloCH · 2019-05-24T11:51:03Z

please review @nextcloud/user_external

lavdnone · 2019-06-01T03:39:43Z

@violoncelloCH thanks, looks great

violoncelloCH · 2019-06-01T16:14:51Z

thanks for the feedback @lavdnone! could you test this?
I know I could approve this PR myself because I didn't open it, but because I've changed quite a lot here, I would like to have a proper review (and test) from someone else :) (cc @nextcloud/user_external)

lavdnone · 2019-06-02T17:37:22Z

@violoncelloCH tested, put in prod, safe to merge

imap groups via domain-part Signed-off-by: none <vlad@teksperts.nyc>

Signed-off-by: none <vlad@teksperts.nyc>

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

…nal parameters wheter to stripe domain and create group based on domain or not Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

…and domain based group creation Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

…r later extendability e.g. nextcloud#69) Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

violoncelloCH · 2019-06-02T21:42:26Z

lib/imap.php

@@ -37,7 +37,7 @@ class OC_User_IMAP extends \OCA\user_external\Base {
 	 * @param boolean $stripeDomain (whether to stripe the domain part from the username or not)
 	 * @param boolean $groupDomain (whether to add the usere to a group corresponding to the domain of the address)
 	 */
-	public function __construct($mailbox, $port = null, $sslmode = null, $domain = null, $stripeDomain = true, $groupDomain = false) {
+	public function __construct($mailbox, $port = null, $sslmode = null, $domain = null, $stripeDomain = false, $groupDomain = false) {


the thing is the current behaviour is to stripe the domain...
that's why I've put this to true by default, so we don't break anything for current setups...

also we only apply it if a restrictig domain is specified...

I wouldn't set it as default either, but as we do it this way in the existing versions, we shouldn't change it now, because it would break existing setups... so I've reverted your last commit, hope it's clear now why :)

violoncelloCH · 2019-06-02T21:50:16Z

thanks for testing this @lavdnone !

kesselb · 2019-06-04T14:22:15Z

I would prefer "stripDomain" over "stripeDomain" ;)

violoncelloCH · 2019-06-05T22:07:59Z

@kesselb you're right... I'm not a native speaker and didn't check that, just took over how others called it... will probably change this naming with a future PR...

lavdnone force-pushed the master branch from a8aa3f4 to ec6cbd6 Compare March 31, 2019 04:07

lavdnone mentioned this pull request Mar 31, 2019

Feature request imap groups via domain-part #10

Closed

violoncelloCH self-requested a review April 1, 2019 09:54

violoncelloCH added enhancement New feature or request help wanted Extra attention is needed labels Apr 14, 2019

lavdnone force-pushed the master branch from 97257ef to a7e9e3c Compare April 28, 2019 03:44

This was referenced May 22, 2019

Update base.php nextcloud/apps#31

Closed

Update imap.php nextcloud/apps#33

Closed

violoncelloCH reviewed May 22, 2019

View reviewed changes

lib/imap.php Outdated Show resolved Hide resolved

violoncelloCH changed the title ~~imap groups via domain~~ optional imap groups via domain & make domain striping optional May 22, 2019

violoncelloCH added this to the 0.6.2 milestone May 22, 2019

violoncelloCH mentioned this pull request May 22, 2019

Document recent database changes for IMAP-Backend #64

Closed

violoncelloCH force-pushed the master branch from 06627eb to ed1c370 Compare May 22, 2019 21:58

violoncelloCH added the 3. to review label May 22, 2019

lavdnone closed this May 24, 2019

lavdnone reopened this May 24, 2019

violoncelloCH removed the help wanted Extra attention is needed label May 24, 2019

violoncelloCH requested review from kosli, sebastiansterk, tflidd, MariusBluem, nerdmaennchen and umgfoin May 24, 2019 11:52

violoncelloCH modified the milestones: 0.6.2, 0.6.3 Jun 1, 2019

lavdnone and others added 7 commits June 2, 2019 13:49

Update base.php

00c4c02

imap groups via domain-part Signed-off-by: none <vlad@teksperts.nyc>

converted to getGroupManager()->createGroup from OC_DB

b012588

Signed-off-by: none <vlad@teksperts.nyc>

👌 IMPROVE: update authors

dd1d9a7

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

👌 IMPROVE: move group creation to imap class && check for two additio…

aeb4476

…nal parameters wheter to stripe domain and create group based on domain or not Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

🐛 FIX: creation of groups

47ee3d6

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

📖 DOC: additional boolean parameters for optional striping of domain …

f99c4da

…and domain based group creation Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

👌 IMPROVE: make it possible to add the user to an array of groups (fo…

8c38759

…r later extendability e.g. nextcloud#69) Signed-off-by: Jonas Sulzer <jonas@violoncello.ch> Signed-off-by: none <vlad@teksperts.nyc>

lavdnone force-pushed the master branch from 14da6a7 to 7b32fac Compare June 2, 2019 17:51

violoncelloCH reviewed Jun 2, 2019

View reviewed changes

violoncelloCH force-pushed the master branch from 7b32fac to 8c38759 Compare June 2, 2019 21:48

violoncelloCH approved these changes Jun 2, 2019

View reviewed changes

violoncelloCH modified the milestones: 0.6.3, 0.6.2 Jun 2, 2019

violoncelloCH merged commit 406e41c into nextcloud:master Jun 2, 2019

This was referenced Jun 3, 2019

hotfix & release v0.6.3 #86

Merged

Update user_external example for nextcloud Mailu/Mailu#1030

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optional imap groups via domain & make domain striping optional #65

optional imap groups via domain & make domain striping optional #65

lavdnone commented Mar 31, 2019 •

edited by violoncelloCH

Loading

violoncelloCH commented Apr 14, 2019

lavdnone commented Apr 15, 2019

violoncelloCH commented May 8, 2019

violoncelloCH commented May 22, 2019

violoncelloCH commented May 22, 2019 •

edited

Loading

violoncelloCH commented May 22, 2019

violoncelloCH commented May 24, 2019

lavdnone commented Jun 1, 2019

violoncelloCH commented Jun 1, 2019

lavdnone commented Jun 2, 2019

violoncelloCH Jun 2, 2019

violoncelloCH Jun 2, 2019

violoncelloCH Jun 2, 2019

violoncelloCH commented Jun 2, 2019

kesselb commented Jun 4, 2019

violoncelloCH commented Jun 5, 2019

optional imap groups via domain & make domain striping optional #65

optional imap groups via domain & make domain striping optional #65

Conversation

lavdnone commented Mar 31, 2019 • edited by violoncelloCH Loading

violoncelloCH commented Apr 14, 2019

lavdnone commented Apr 15, 2019

violoncelloCH commented May 8, 2019

violoncelloCH commented May 22, 2019

violoncelloCH commented May 22, 2019 • edited Loading

violoncelloCH commented May 22, 2019

violoncelloCH commented May 24, 2019

lavdnone commented Jun 1, 2019

violoncelloCH commented Jun 1, 2019

lavdnone commented Jun 2, 2019

violoncelloCH Jun 2, 2019

Choose a reason for hiding this comment

violoncelloCH Jun 2, 2019

Choose a reason for hiding this comment

violoncelloCH Jun 2, 2019

Choose a reason for hiding this comment

violoncelloCH commented Jun 2, 2019

kesselb commented Jun 4, 2019

violoncelloCH commented Jun 5, 2019

lavdnone commented Mar 31, 2019 •

edited by violoncelloCH

Loading

violoncelloCH commented May 22, 2019 •

edited

Loading