Add support for comma-separated groups in group mapping attribute #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janepie
reviewed
Dec 6, 2024
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/group-provisioning-string-support
branch
from
c95217a to
c39164a
Compare
janepie
approved these changes
Dec 6, 2024
edward-ly
reviewed
Dec 6, 2024
| // support values like group1,group2 | ||
| if (is_string($groups)) { | ||
| $groups = explode(',', $groups); | ||
| $groups = array_filter($groups); |
There was a problem hiding this comment.
In case there is any excess whitespace in the string, maybe it would also be a good idea to use trim/mb_trim to remove them.
wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IdPs can't provide JSON values in token attributes.