Optionally keep userinfo validator for api calls only, use all providers #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Oct 5, 2021
… might be missing from externally created tokens Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/userinfo-for-api-validation
branch
from
8f8fbcf
to
dc73fec
Compare
…irst Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
changed the title
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
|
Some news:
|
juliusknorr
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case (which I faced IRL 😁) the uid attribute is not in the token but is returned by the userinfo endpoint.
In fact, when receiving an api call, we don't know how the OIDC token was generated and the associated claims.