Improve failure handling in controllers #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
changed the title
lib/Controller/Id4meController.php
Outdated
| @@ -117,6 +131,8 @@ public function __construct( | |||
| $this->id4MeMapper = $id4MeMapper; | |||
| $this->config = $config; | |||
| $this->l10n = $l10n; | |||
| $this->loginController = $loginController; | |||
There was a problem hiding this comment.
Injecting a controller into another cries for just creating a shared base class instead 🙈
nickvergessen
approved these changes
Apr 21, 2023
julien-nc
force-pushed
the
fix/bruteforce-protection
branch
3 times, most recently
from
0d327db
to
c3d54af
Compare
juliusknorr
approved these changes
Apr 24, 2023
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ollers Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/bruteforce-protection
branch
from
c3d54af
to
c249585
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handling of failures in: