Fix and refactor upsert command #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
fix/858/fix-and-refactor-upsert-command
branch
2 times, most recently
from
2c173e4
to
30f8765
Compare
juliusknorr
reviewed
May 8, 2024
lib/Command/UpsertProvider.php
Outdated
| @@ -44,6 +44,35 @@ class UpsertProvider extends Base { | |||
| /** @var ICrypto */ | |||
| private $crypto; | |||
|
|
|||
| private const EXTRA_OPTIONS = [ | |||
| 'unique-uid' => ['shortcut' => null, 'mode' => InputOption::VALUE_OPTIONAL, 'description' => 'Flag if unique user ids shall be used or not. 1 to enable (default), 0 to disable', 'default' => null, 'setting_key' => ProviderService::SETTING_UNIQUE_UID], | |||
There was a problem hiding this comment.
Would prefer to add linebreaks to the nested array to make it a bit more readable ;)
juliusknorr
approved these changes
May 8, 2024
…or upsert command Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/858/fix-and-refactor-upsert-command
branch
from
ab34683
to
c6d2948
Compare
|
Thanks for the review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #858