Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Improve the stub so it's not confusing IDEs #862

Merged
merged 1 commit into from
May 10, 2024
Merged

fix(tests): Improve the stub so it's not confusing IDEs #862

merged 1 commit into from
May 10, 2024

Conversation

nickvergessen
Copy link
Member

Steps

  1. Checkout this app
  2. Checkout another app that uses commands
  3. Open the source code of a command
  4. See that your IDE complains about using returned voids
Before After
Bildschirmfoto vom 2024-05-10 09-00-20 Bildschirmfoto vom 2024-05-10 09-00-05

@nickvergessen
fix(tests): Improve the stub so it's not confusing IDEs
b512a42 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review labels May 10, 2024
@nickvergessen nickvergessen requested a review from julien-nc May 10, 2024 07:02
@nickvergessen nickvergessen self-assigned this May 10, 2024
julien-nc
julien-nc approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@julien-nc julien-nc merged commit a17af82 into main May 10, 2024
38 checks passed
@julien-nc julien-nc deleted the bugfix/noid/improve-command-base-stub branch May 10, 2024 08:14
@nickvergessen
Copy link
Member Author

one of them also exists in older stable branches, would be cool to backport it 🙈

@nickvergessen
Copy link
Member Author

ah, they all use main. So it will heal. cool!

@julien-nc julien-nc mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @julien-nc