Backchannel logout endpoint should only return 200 or 400 #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if either protection makes sense on the logout operation. I could be wrong, but I don't see what kind of vulnerability could be exploited from this endpoint alone. |
|
As the backchannel logout endpoint is public, one can bruteforce it to logout people. But the logout token is pretty long so the chances such attack succeeds are very low. Even if it succeeds, it's just logging out someone. I thought this endpoint could be the target of a DoS attack because it makes NC do a network request to the Idp (to the discovery endpoint) but this is cached. @edward-ly I agree, it seems ok to not put any protection there. Waiting for the ✔️ of @juliushaertl to merge. |
juliusknorr
approved these changes
Oct 8, 2024
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/backchannel-logout-always-400-on-error
branch
from
8113016
to
9b5d6c6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://openid.net/specs/openid-connect-backchannel-1_0.html#rfc.section.2.6 , the backchannel logout should only respond with 200 or 400 status code responses. With bruteforce protection, 429 can be returned.
Should we add a rate limit instead? What would be reasonable values?