feat: add support for de-provisioning users #960
Merged
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
reviewed
Oct 10, 2024
edward-ly
force-pushed
the
feat/de-provision-user
branch
from
45936f2
to
e43c364
Compare
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
feat/de-provision-user
branch
from
e43c364
to
7013ec3
Compare
julien-nc
requested changes
Oct 11, 2024
There was a problem hiding this comment.
@NoCSRFRequired is missing.
We could also make this an OCS controller. If you want to do it in this PR you can, otherwise we'll do it later.
Also, if a 404 is returned, I think it's better if the payload is empty or something like ['error' => 'User not found'].
Signed-off-by: Edward Ly <contact@edward.ly>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #902.