Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📬 Email before account deletion #486

Merged
merged 9 commits into from
Nov 17, 2022
Merged

📬 Email before account deletion #486

merged 9 commits into from
Nov 17, 2022

Commits on Nov 14, 2022

  1. Use public OCP\BackgroundJob\TimedJob class 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    25df2a9 View commit details
    Browse the repository at this point in the history

  2. Use an existing IToken implementation after removal of DefaultToken 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    7aec78e View commit details
    Browse the repository at this point in the history

  3. Add unit tests 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    1f07f9d View commit details
    Browse the repository at this point in the history

  4. Start with reminder logic 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    352ae1f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Move the logic to a service for better testing 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    9a1711c View commit details
    Browse the repository at this point in the history

  2. Document 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    3a39062 View commit details
    Browse the repository at this point in the history

  3. Log a warning when the user has no email configured 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    8899aba View commit details
    Browse the repository at this point in the history

  4. Fix tests 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c815c32 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Fix review comments 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    069f7a5 View commit details
    Browse the repository at this point in the history