Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Nextcloud 30 release #748

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Prepare Nextcloud 30 release #748

merged 6 commits into from
Jul 30, 2024

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen
fix: Use compact license and constructor
3ddd179 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix: Cleanup tests
0264ed7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Add coding-standards
aa29279 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix!: Bump Nextcloud requirements to 28-30
fc959c7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Update workflows
9e31379 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen requested a review from mejo- July 30, 2024 09:49
@nickvergessen nickvergessen self-assigned this Jul 30, 2024
@cypress Cypress
Copy link

cypress bot commented Jul 30, 2024 •
edited
Loading


Test summary

1 • 0 • 0 • 0 • Flakiness 0

Run details
Project User retention
Status Passed
Commit 7071fe6
Started Jul 30, 2024 10:02 AM
Ended Jul 30, 2024 10:02 AM
Duration 00:11 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

mejo-
mejo- approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

Changes look good to me - only one comment.

.github/workflows/phpunit-sqlite.yml Show resolved Hide resolved
@mejo-
Copy link
Member

mejo- commented Jul 30, 2024

Seems like we'll have to adjust the merge requirements because the expected Nextcloud CI job doesn't exist anymore. It's named static-psalm-analysis now.

@nickvergessen
Copy link
Member Author

Seems like we'll have to adjust the merge requirements because the expected Nextcloud CI job doesn't exist anymore. It's named static-psalm-analysis now.

Already fixed

@nickvergessen
ci: Add phpunit-mysql to test the full range matrix
7071fe6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Also required mysql now, that runs php 8.3 against all servers and all php versions against master

@nickvergessen nickvergessen merged commit 7b4bdc7 into main Jul 30, 2024
37 checks passed
@nickvergessen nickvergessen deleted the prepare/30 branch July 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @mejo-