migrate away from removed event dispatcher #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
event-dispatcher
branch
3 times, most recently
from
5e0391c to
06721ee
Compare
juliusknorr
reviewed
Aug 9, 2023
lib/UserBackend.php
Outdated
| @@ -35,8 +35,8 @@ | |||
| use OCP\IUserBackend; | |||
| use OCP\IUserManager; | |||
| use OCP\User\Events\UserChangedEvent; | |||
| use OCP\User\Events\UserFirstTimeLoggedInEvent; | |||
There was a problem hiding this comment.
Breaking, since until now we support Nextcloud 25-27, but I guess 28 might be a good cut then to have another stable branch
juliusknorr
reviewed
Aug 9, 2023
|
It's needed to get the kerberos sso smb working (and fixing the currently failing CI for it), but for now I can continue testing it from the branch |
1 task
|
I am going to branch off to stable-5.2 and adapt master to cater for 28. That would pave the way for this PR. |
ArtificialOwl
approved these changes
Sep 6, 2023
|
Tested on globalscale setup |
Signed-off-by: Robin Appelman <robin@icewind.nl>
blizzz
force-pushed
the
event-dispatcher
branch
from
06721ee to
d153b6f
Compare
|
adjusted (and rebased) according to #767 (comment) |
blizzz
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event dispatcher is dead, long live the event dispatcher