Do not open the sidebar automatically on small widths #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/noid/dont-open-sidebar-on-small-screens
branch
from
04e99c1
to
311029f
Compare
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/noid/dont-open-sidebar-on-small-screens
branch
from
311029f
to
b4876c1
Compare
skjnldsv
reviewed
Jan 31, 2023
| @@ -907,13 +913,15 @@ export default { | |||
|
|
|||
| /** | |||
| * Show the sharing sidebar | |||
| * | |||
| * @param {boolean} openSidebar open the sidebar, defaults to true | |||
skjnldsv
reviewed
Jan 31, 2023
| // Open the sidebar sharing tab | ||
| // TODO: also hide figure, needs a proper method for it in server Sidebar | ||
|
|
||
| if (OCA?.Files?.Sidebar) { | ||
| if (OCA?.Files?.Sidebar && openSidebar) { |
There was a problem hiding this comment.
This means we will never be able to open the sidebar on small screens
There was a problem hiding this comment.
Yeah, it was just a test but didnt work anyway. I will have a look together with @Pytal on the problem. Or if you have some suggestions, please note them down :)
|
Looks like this is only a server problem |
|
No, looks like it is actually required |
|
actually only a server problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon L szaimen@e.mail.de