Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proper layout for split view #2549

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: Proper layout for split view #2549

merged 2 commits into from
Sep 27, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 19, 2024

Fix nextcloud/richdocuments#3357

Requires companion PR for Collabora at nextcloud/richdocuments#4050

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Sep 19, 2024
Copy link

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well when paired with nextcloud/richdocuments#4050

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/compare-side-by-side branch from 20270fd to 93d9fb8 Compare September 20, 2024 09:19
@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
Copy link
Contributor

nfebe commented Sep 27, 2024

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 27, 2024
@nfebe
Copy link
Contributor

nfebe commented Sep 27, 2024

@elzody I added backport request for stable28, hopefully that is what you want?

@elzody
Copy link

elzody commented Sep 27, 2024

@fenn-cs I would also need in for stable29 and stable30 if possible, is the bot only working for certain users in this repo?

@nfebe
Copy link
Contributor

nfebe commented Sep 27, 2024

@fenn-cs I would also need in for stable29 and stable30 if possible, is the bot only working for certain users in this repo?

There could be some restrictions not sure. However, the backports won't happen until this is merged. You can find out just add a backport comment here and see if it works.

Example copy paste : /backport to stable29

@elzody
Copy link

elzody commented Sep 27, 2024

@fenn-cs Indeed, wasn't working for me, I think it's restricted to this nextcloud-server group or something on GH. No worries

@nfebe
Copy link
Contributor

nfebe commented Sep 27, 2024

/backport to stable29

@nfebe
Copy link
Contributor

nfebe commented Sep 27, 2024

/backport to stable30

@nfebe nfebe merged commit 55c6dd4 into master Sep 27, 2024
30 checks passed
@nfebe nfebe deleted the fix/compare-side-by-side branch September 27, 2024 14:42
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side by side comparison of document versions broken
4 participants